Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix routing issues that occur when using setIframe. #50

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Fix routing issues that occur when using setIframe. #50

merged 4 commits into from
Sep 26, 2023

Conversation

jasoncomes
Copy link
Contributor

@jasoncomes jasoncomes commented Sep 26, 2023 •
edited

  • Increased the patch version to v2.2.2.
  • Updated the Node Version to match the version used in the Application, allowing npm links to function correctly. It is important to note that linking npm packages is limited to the version of Node on which they were created.
  • Added more explicit routing to setIframe.
  • The urlJoin function was stripping the trailing slash, causing issues with the 401 error and e2e errors.

You can find the PR where we implemented urlJoin.

There is an issue with joinUrl, which does not preserve trailing slashes.

@jasoncomes jasoncomes changed the title Fix Routing issues when using setIframe Fix routing issues that occur when using setIframe. Sep 26, 2023
@jasoncomes jasoncomes merged commit f47d0e2 into main Sep 26, 2023
@jasoncomes jasoncomes deleted the jc/routing-issues-causing-401s branch September 26, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorreece taylorreece taylorreece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasoncomes @taylorreece