Conversation
@prisma/cli-engine 0.6.2 replaces {bin} when a run settles, so next-step
hints and error advice name the running binary. The ORM was still pinned
to 0.6.1, which left the placeholder in the text users see.
Fixes prisma#30496.
Signed-off-by: Michał Furgała <83299832+00200200@users.noreply.github.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: prisma/orm/.coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (44)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates ChangesCLI hints and dependency alignment
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~15 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change makes CLI hints show the real binary name instead of a literal placeholder. It updates dependency pins and tests, and no concrete merge-blocking risk was found. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change makes suggested commands name the running CLI instead of showing a placeholder. The reviewed changes do not show a new production entrypoint, privileged action, or security-control change. The dependency’s implementation and deployment compatibility were not independently verified. Retained concerns Security review detailsSecurity Blast Radius
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Closing as superseded by #30503, merged September 30. Upstream already includes the engine 0.6.2 upgrade and rendered CLI placeholder fixes. Keeping this PR open would duplicate that work and conflict with the intentional preservation of placeholders in raw command data. |
Linked issue
Fixes #30496
Summary
Next-step hints and error advice still printed a literal
{bin}because this repository pinned@prisma/cli-engine0.6.1. Engine 0.6.2 (prisma/prisma-cli#313) substitutes the running binary when a run settles. This PR moves every pin to 0.6.2 and locks the rendered output so the placeholder cannot leak again.Testing performed
packages/1-framework/3-tooling/cli/test/orm/bin-placeholder.test.ts: human next-step lines and the JSON error envelope must containprisma-testand must not contain{bin}.pnpm --filter @internal/cli test -- test/orm/bin-placeholder.test.ts test/orm/define-command.test.ts test/orm/db-update.test.ts test/orm/db-init.test.ts test/orm/db-sign.test.ts test/orm/db-verify.test.ts test/orm/migrate.test.ts test/orm/migration-plan.test.ts test/orm/migration-status.test.ts test/orm/ref-set.test.ts test/orm/contract-print.test.ts— 11 files, 213 passed.pnpm --filter @internal/cli typecheckpnpm exec biome check --error-on-warningson the changed test files.Settled-output assertions that go through
createTestClinow expectprisma-test. Factory tests that assert{bin}before settlement are unchanged.Skill update
n/a — command packages still write
{bin}in hints. The engine substitutes the binary name at render time; the authoring convention in skills is unchanged.Checklist
git commit -s) per the DCO. The DCO status check will block merge if any commit is missing aSigned-off-by:trailer.n/aif the change is doc-only / refactor with no behavioural delta).fix(cli): …). External contributions do not have LinearTML-NNNNtickets.n/a — internal only).Notes for the reviewer
prisma/prisma-cli#314 tracks dropping the temporary 0.6.1 conformance exception once
@prisma/orm-toolchainpeers 0.6.2. The composer side of that move is prisma/composer#325.Summary by CodeRabbit
prisma-testinstead of the{bin}placeholder. This applies to follow-up commands, error advice, and serialized error output, making the commands shown in those messages directly recognizable.