Minor cleanup

printfn · Dec 6, 2024 · 3fb08f4 · 3fb08f4
1 parent 9687d3d
commit 3fb08f4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/web/src/App.tsx b/web/src/App.tsx
@@ -43,7 +43,7 @@ function NewTabLink({ children, href }: { children: ReactNode; href: string }) {
 
 export default function App({ widget = false }: { widget?: boolean }) {
 	const [output, setOutput] = useState<ReactNode>(widget ? <></> : exampleContent);
-	const { currentInput, addToHistory, onInput, upArrow, downArrow } = useCurrentInput();
+	const { currentInput, submit, onInput, upArrow, downArrow } = useCurrentInput();
 	const [variables, setVariables] = useState('');
 	const [hint, setHint] = useState('');
 	useEffect(() => {
@@ -103,7 +103,7 @@ export default function App({ widget = false }: { widget?: boolean }) {
 
 			startTransition(async () => {
 				const request = <p>{`> ${currentInput}`}</p>;
-				addToHistory(currentInput);
+				submit();
 				const fendResult = await fend(currentInput, 1000000000, variables);
 				if (!fendResult.ok && fendResult.message === 'cancelled') {
 					return;
@@ -124,7 +124,7 @@ export default function App({ widget = false }: { widget?: boolean }) {
 				inputHint.current?.scrollIntoView();
 			});
 		},
-		[currentInput, addToHistory, variables, onInput, downArrow, upArrow],
+		[currentInput, submit, variables, onInput, downArrow, upArrow],
 	);
 	useEffect(() => {
 		document.addEventListener('click', focus);

diff --git a/web/src/hooks/useCurrentInput.ts b/web/src/hooks/useCurrentInput.ts
@@ -2,7 +2,7 @@ import { FormEvent, useCallback, useState } from 'react';
 import { useHistory } from './useHistory';
 
 export function useCurrentInput() {
-	const { history, addToHistory: saveToHistory } = useHistory();
+	const { history, addToHistory } = useHistory();
 	const [currentInput, setCurrentInput] = useState('');
 	const [navigation, setNavigation] = useState(0);
 
@@ -53,13 +53,10 @@ export function useCurrentInput() {
 		navigate('down');
 	}, [navigate]);
 
-	const addToHistory = useCallback(
-		(newEntry: string) => {
-			saveToHistory(newEntry);
-			setNavigation(0);
-		},
-		[saveToHistory],
-	);
+	const submit = useCallback(() => {
+		addToHistory(currentInput);
+		setNavigation(0);
+	}, [currentInput, addToHistory]);
 
-	return { currentInput, addToHistory, onInput, downArrow, upArrow };
+	return { currentInput, submit, onInput, downArrow, upArrow };
 }