Collecting #13
Merged
Collecting #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding CollectingSubsystem and adding setSpeedCommand and setSpeedUntilFeedCommand and adding CollectingConstants
noamgo
requested changes
Jan 20, 2024
src/main/java/frc/robot/commands/CollectingCommands/setSpeedCommand.java
Outdated
Show resolved
Hide resolved
Comment on lines
21
to
22
| public void initialize() {} | ||
|
|
There was a problem hiding this comment.
You need to set motor speed
Comment on lines
35
to
41
| public boolean isFinished() { | ||
| if (collectingSubsystem.getSwitch()){ | ||
| return true; | ||
| } | ||
| else{ | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Can be shorten to
return (collectingSubsystem.getSwitch());
changing to instant command changing limitswithc to lazersensor giving setspeeduntilfeedCommand speed variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding CollectingSubsystem and adding setSpeedCommand and setSpeedUntilFeedCommand and adding CollectingConstants