Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feeder #10

Merged
merged 6 commits into from
Jan 20, 2024
Merged

Feeder #10

merged 6 commits into from
Jan 20, 2024

Conversation

NirNadiv
Copy link
Contributor

סיימתי את הסאבסיסטם. מה צריך להוסיף/לשנות?

@NirNadiv
Started feeder Subsystem
8c58b2f 
kaki baki
@NirNadiv
finished feeder subsystem
382d30a 
i added a set speed function, and two constants one for a motor id and another form speed.
ori-coval
ori-coval requested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@ori-coval ori-coval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good waiting for the commands

noamgo
noamgo reviewed Jan 20, 2024
View reviewed changes
Copy link
Contributor

@noamgo noamgo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you did not use singleton in any of the commands

@ori-coval ori-coval merged commit 9888dd9 into main Jan 20, 2024
1 check passed
@ori-coval ori-coval deleted the Feeder branch January 20, 2024 11:39
@ori-coval
Merge branch 'main' of https://github.com/primo4586/RobotCode2024 int…
87d7f1a 
…o Feeder

# Conflicts:
#	src/main/java/frc/robot/Constants.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamgo noamgo noamgo left review comments

@ori-coval ori-coval ori-coval requested changes

Assignees

@NirNadiv NirNadiv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NirNadiv @noamgo @ori-coval