fix: Add an indicator for disabled ActionList items (e.g. in a SelectPanel) #6246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 27527b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
staff
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
langermank
reviewed
Jun 28, 2025
| &::after { | ||
| @mixin activeIndicatorLine; | ||
| /* stylelint-disable-next-line primer/colors */ | ||
| background: var(--fgColor-muted); |
There was a problem hiding this comment.
Suggested change
| background: var(--fgColor-muted); | |
| background: var(--bgColor-neutral-emphasis); |
| /* gray accent line */ | ||
| &::after { | ||
| @mixin activeIndicatorLine; | ||
| /* stylelint-disable-next-line primer/colors */ |
There was a problem hiding this comment.
Suggested change
| /* stylelint-disable-next-line primer/colors */ |
Comment on lines
+346
to
+349
| background: transparent; | ||
|
|
||
| /* provides a visual indication of the current item for Windows high-contrast mode */ | ||
| outline: 2px solid var(--control-transparent-bgColor-selected); |
There was a problem hiding this comment.
Suggested change
| background: transparent; | |
| /* provides a visual indication of the current item for Windows high-contrast mode */ | |
| outline: 2px solid var(--control-transparent-bgColor-selected); | |
| background: var(--control-transparent-bgColor-disabled); |
I wonder if this might look a little cleaner? Just guessing, I haven't tried it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/accessibility-audits/issues/11962 (Hubber access only)
This PR adds new indicator styles for disabled ActionList items that are hovered or selected with arrow keys, and a new Storybook story to demo them: “SelectPanel > Features > With Disabled Items”.
Previously, there were no indicator styles at all, so focus would seem to “disappear” when moving past a disabled item.
Note
The
primer_react_select_panel_with_modern_action_listfeature flag must be enabled.Before
Screen recording, without audio, showing how focus “disappeared” before.
Before.mov
After
Screen recording, without audio, showing how focus indication is now preserved.
After.mov
Changelog
New
Changed
ActionListitems now have a visible indicator when hovered or selected.Removed
Rollout strategy
Testing & Reviewing
Check out the newly-added Storybook story. I’ll update this PR body with a link once it’s available.
Merge checklist