Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drag and drop in action list example #5594

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Remove drag and drop in action list example #5594

merged 4 commits into from
Jan 27, 2025

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Jan 24, 2025

Closes: https://github.com/github/accessibility-audits/issues/10141

Drag and drop is complicated. It's not something we can accessibly implement in this storybook example!

We want to discourage consumers from using Drag and drop that outside of the shared components implementation in dotcom, per https://github.com/github/accessibility-audits/issues/10141#issuecomment-2613423227.

Changelog

Removed

  • Drag and drop ActionList example

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@khiga8 khiga8 requested a review from a team as a code owner January 24, 2025 22:03
@khiga8 khiga8 requested a review from mperrotti January 24, 2025 22:03
@khiga8 khiga8 added the skip changeset This change does not need a changelog label Jan 24, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5594 January 24, 2025 22:05 Inactive
Copy link
Contributor

github-actions bot commented Jan 24, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.41 KB (0%)
packages/react/dist/browser.umd.js 104.88 KB (0%)

@khiga8 khiga8 marked this pull request as draft January 24, 2025 22:26
@khiga8 khiga8 marked this pull request as ready for review January 27, 2025 17:20
Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: c2ea257

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-5594 January 27, 2025 17:22 Inactive
Copy link
Contributor

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and I definitely agree! I think we can remove the react-dnd package now too 🤩 I can follow up on that in another PR though if you want to just ship this change 😁

@khiga8
Copy link
Contributor Author

khiga8 commented Jan 27, 2025

@TylerJDev Ooh nice catch! Will do! :)

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 27, 2025
@khiga8
Copy link
Contributor Author

khiga8 commented Jan 27, 2025

I don't think dnd is used anywhere but kicked off https://github.com/github/github/actions/runs/12997782282 per build suggestion.

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/359511

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 27, 2025
@TylerJDev
Copy link
Contributor

@khiga8, the test failures in the integration test PR are unrelated to this change, and should be resolved once 37.11.0 is merged in Dotcom. Feel free to merge this PR! 😄

@khiga8 khiga8 added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 0895e47 Jan 27, 2025
42 checks passed
@khiga8 khiga8 deleted the kh-fix-10141 branch January 27, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants