-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove drag and drop in action list example #5594
Conversation
size-limit report 📦
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and I definitely agree! I think we can remove the react-dnd
package now too 🤩 I can follow up on that in another PR though if you want to just ship this change 😁
@TylerJDev Ooh nice catch! Will do! :) |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
I don't think |
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/359511 |
🔴 golden-jobs completed with status |
@khiga8, the test failures in the integration test PR are unrelated to this change, and should be resolved once |
Closes: https://github.com/github/accessibility-audits/issues/10141
Drag and drop is complicated. It's not something we can accessibly implement in this storybook example!
We want to discourage consumers from using Drag and drop that outside of the shared components implementation in dotcom, per https://github.com/github/accessibility-audits/issues/10141#issuecomment-2613423227.
Changelog
Removed
Rollout strategy
Testing & Reviewing
Merge checklist