Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Primaza-Identity-Namespace #39

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

fbm3307
Copy link
Member

@fbm3307 fbm3307 commented Aug 2, 2023

Adding Primaza-Identity-Namespace

@fbm3307 fbm3307 force-pushed the identityns branch 6 times, most recently from eea00a9 to 43ab270 Compare August 3, 2023 17:01
@fbm3307 fbm3307 force-pushed the identityns branch 2 times, most recently from 26d4e58 to af7c19b Compare August 4, 2023 13:05
@fbm3307 fbm3307 requested a review from mmulholla August 4, 2023 13:05
@fbm3307 fbm3307 force-pushed the identityns branch 4 times, most recently from 74b524b to 4ef869c Compare August 9, 2023 12:08
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

README.md Outdated Show resolved Hide resolved
scripts/src/primazatest/runtest.py Outdated Show resolved Hide resolved
scripts/src/primazactl/cmd/apply/cluster_environment.py Outdated Show resolved Hide resolved
scripts/src/primazatest/runtest.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fbm3307 fbm3307 force-pushed the identityns branch 8 times, most recently from a7a2ab9 to 10b8e00 Compare August 10, 2023 11:20
@fbm3307 fbm3307 requested a review from filariow August 10, 2023 12:06
@fbm3307 fbm3307 requested a review from mmulholla August 10, 2023 12:06
mmulholla
mmulholla previously approved these changes Aug 10, 2023
Signed-off-by: Feny Mehta <[email protected]>

Adding Primaza-Identity-Namespace

Signed-off-by: Feny Mehta <[email protected]>

Name change to service account

Signed-off-by: Feny Mehta <[email protected]>

updatd the test

Signed-off-by: Feny Mehta <[email protected]>

fixing tests and linter

Signed-off-by: Feny Mehta <[email protected]>

Test case1

Signed-off-by: Feny Mehta <[email protected]>

Test8

Signed-off-by: Feny Mehta <[email protected]>

Test9

Signed-off-by: Feny Mehta <[email protected]>

Test10

Signed-off-by: Feny Mehta <[email protected]>

Test passing1

Signed-off-by: Feny Mehta <[email protected]>

Changing the - to _

Signed-off-by: Feny Mehta <[email protected]>

Updating messages

Signed-off-by: Feny Mehta <[email protected]>

Review Comments

Signed-off-by: Feny Mehta <[email protected]>
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@filariow filariow merged commit 556c058 into primaza:main Aug 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants