-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Primaza-Identity-Namespace #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbm3307
force-pushed
the
identityns
branch
6 times, most recently
from
August 3, 2023 17:01
eea00a9
to
43ab270
Compare
mmulholla
reviewed
Aug 3, 2023
fbm3307
force-pushed
the
identityns
branch
2 times, most recently
from
August 4, 2023 13:05
26d4e58
to
af7c19b
Compare
fbm3307
force-pushed
the
identityns
branch
4 times, most recently
from
August 9, 2023 12:08
74b524b
to
4ef869c
Compare
filariow
requested changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits
filariow
reviewed
Aug 9, 2023
mmulholla
requested changes
Aug 9, 2023
filariow
reviewed
Aug 9, 2023
fbm3307
force-pushed
the
identityns
branch
8 times, most recently
from
August 10, 2023 11:20
a7a2ab9
to
10b8e00
Compare
mmulholla
previously approved these changes
Aug 10, 2023
filariow
reviewed
Aug 10, 2023
filariow
reviewed
Aug 10, 2023
filariow
reviewed
Aug 10, 2023
Signed-off-by: Feny Mehta <[email protected]> Adding Primaza-Identity-Namespace Signed-off-by: Feny Mehta <[email protected]> Name change to service account Signed-off-by: Feny Mehta <[email protected]> updatd the test Signed-off-by: Feny Mehta <[email protected]> fixing tests and linter Signed-off-by: Feny Mehta <[email protected]> Test case1 Signed-off-by: Feny Mehta <[email protected]> Test8 Signed-off-by: Feny Mehta <[email protected]> Test9 Signed-off-by: Feny Mehta <[email protected]> Test10 Signed-off-by: Feny Mehta <[email protected]> Test passing1 Signed-off-by: Feny Mehta <[email protected]> Changing the - to _ Signed-off-by: Feny Mehta <[email protected]> Updating messages Signed-off-by: Feny Mehta <[email protected]> Review Comments Signed-off-by: Feny Mehta <[email protected]>
filariow
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Primaza-Identity-Namespace