Skip to content

multiline strings should be indented and grouped#1436

Open
Janther wants to merge 2 commits intomainfrom
multiline-strings
Open

multiline strings should be indented and grouped#1436
Janther wants to merge 2 commits intomainfrom
multiline-strings

Conversation

@Janther
Copy link
Member

@Janther Janther commented Mar 1, 2026

⚠️ ANTLR still uses the old format. Since it's deprecated and it's just a format difference which doesn't contain any error I'm ok with ignoring it for now.

// Original
contract MultipartStrings {
  function multilineString() {
    bytes hex1 = hex'DeadBeef00' hex'DeadBeef01' hex'DeadBeef02' hex'DeadBeef03';
    hex1 = hex'DeadBeef0a' hex'DeadBeef0b' hex'DeadBeef0c' hex'DeadBeef0d';
    string str = 'DeadBeef00' 'DeadBeef01' 'DeadBeef02' 'DeadBeef03';
    str = 'DeadBeef0a' 'DeadBeef0b' 'DeadBeef0c' 'DeadBeef0d';
    string uni = unicode'DeadBeef00🦄' unicode'DeadBeef01🦄' unicode'DeadBeef02🦄' unicode'DeadBeef03🦄';
    uni = unicode'DeadBeef0a🦄' unicode'DeadBeef0b🦄' unicode'DeadBeef0c🦄' unicode'DeadBeef0d🦄';
  }
}

// Before
contract MultipartStrings {
  function multilineString() {
        bytes hex1 = hex"DeadBeef00"
        hex"DeadBeef01"
        hex"DeadBeef02"
        hex"DeadBeef03";
        hex1 = hex"DeadBeef0a"
        hex"DeadBeef0b"
        hex"DeadBeef0c"
        hex"DeadBeef0d";
        string str = "DeadBeef00"
        "DeadBeef01"
        "DeadBeef02"
        "DeadBeef03";
        str = "DeadBeef0a"
        "DeadBeef0b"
        "DeadBeef0c"
        "DeadBeef0d";
        string uni = unicode"DeadBeef00🦄"
        unicode"DeadBeef01🦄"
        unicode"DeadBeef02🦄"
        unicode"DeadBeef03🦄";
        uni = unicode"DeadBeef0a🦄"
        unicode"DeadBeef0b🦄"
        unicode"DeadBeef0c🦄"
        unicode"DeadBeef0d🦄";
    }
}

// New
contract MultipartStrings {
    function multilineString() {
        bytes hex1 =
            hex"DeadBeef00"
            hex"DeadBeef01"
            hex"DeadBeef02"
            hex"DeadBeef03";
        hex1 =
            hex"DeadBeef0a"
            hex"DeadBeef0b"
            hex"DeadBeef0c"
            hex"DeadBeef0d";
        string str =
            "DeadBeef00"
            "DeadBeef01"
            "DeadBeef02"
            "DeadBeef03";
        str =
            "DeadBeef0a"
            "DeadBeef0b"
            "DeadBeef0c"
            "DeadBeef0d";
        string uni =
            unicode"DeadBeef00🦄"
            unicode"DeadBeef01🦄"
            unicode"DeadBeef02🦄"
            unicode"DeadBeef03🦄";
        uni =
            unicode"DeadBeef0a🦄"
            unicode"DeadBeef0b🦄"
            unicode"DeadBeef0c🦄"
            unicode"DeadBeef0d🦄";
    }
}

@Janther Janther requested a review from fvictorio March 1, 2026 20:27
Copy link
Member

@fvictorio fvictorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants