Skip to content

Conversation

BastelPichi
Copy link

This draft adds haptics to the app. Ive chosen to only have two types of feedback, as itd be hard to tell them apart if they are all just different lengths, and "patterns" arent easely supported on older devices.

@raphaelm
Copy link
Member

The PR looks promising, is it intentionally still a "draft"?

@BastelPichi BastelPichi marked this pull request as ready for review February 24, 2025 18:22
@BastelPichi
Copy link
Author

I wasnt aware you couldn't already review the PR 🙃

@BastelPichi
Copy link
Author

Any feedback on this @raphaelm?

@raphaelm
Copy link
Member

I'm on vacation, cc @pc-coholic @robbi5

@robbi5
Copy link
Contributor

robbi5 commented Jul 28, 2025

Thanks for the PR. Supporting only two types of feedback is a bit limiting - especially if the "needs attention" ticket flag also vibrates identical to either a "not allowed" ticket (like its right now) or a "everything's fine, come in" ticket. I think that will lead to more confusion and human errors while checking.

A few weeks ago, I've already had a look and played around with different vibration lenghts/patterns, but then 🐿️ away to other tasks and forgot to post an comment here. Do you have any notes about the support problems with patterns on older devices? The API looked for me like there are good ways for fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants