Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port pokered's comments about NullChar #107

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

SatoMew
Copy link
Contributor

@SatoMew SatoMew commented Jul 26, 2023

As far as I'm aware, it's unused like in pokered, pokeyellow, and pokegold, at least in the context of the official demo mode itself.

@vulcandth
Copy link
Collaborator

Can you change this line as well above it?

-dict 0, NullChar
+dict "<NULL>", NullChar

@SatoMew
Copy link
Contributor Author

SatoMew commented Jul 27, 2023

Can you change this line as well above it?

Certainly! Thank you for pointing it out 🙂

@vulcandth vulcandth merged commit 2665420 into pret:master Jul 27, 2023
1 check passed
@SatoMew SatoMew deleted the nullchar branch July 27, 2023 21:29
@SatoMew SatoMew restored the nullchar branch July 27, 2023 21:30
@SatoMew SatoMew deleted the nullchar branch July 27, 2023 21:30
@SatoMew SatoMew restored the nullchar branch July 27, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants