Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Bill's brother to Bill's older sister #1132

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

metallicity
Copy link
Contributor

I noticed that NPC attached to BillsBrotherScript had a sprite of SPRITE_POKEFAN_F, and wondered if the labels here were maybe incorrect. While I couldn't find anything beyond the sprite itself that seemed particularly definitive, the same house in HGSS also used a similar sprite, and Bulbapedia currently describes Bill as having two sisters (rather than a sister and a brother), so I went ahead and wrote up a commit for all the related renames.

Bill having two sisters does introduce some potential for naming collisions (i.e., BillsSisterScript), so I used BillsYoungerSister and BillsOlderSister to avoid this. The Goldenrod NPC being younger than Bill is perhaps a bit more clear from the in-game text/sprites, but Brent's phone gossip script about "Bill's younger sister" would technically be ambiguous if both were younger than Bill, and regardless the Fuchsia NPC would be the older of Bill's two sisters.

@vulcandth
Copy link
Collaborator

Just wanted to leave a comment, that we haven't forgotten about this, but have been a bit busy with some life and other projects. I'll need to review your references and look over everything; hopefully have an update for you this weekend. Thank you for the contribution regardless 😄

@Rangi42 Rangi42 merged commit 0abd8a7 into pret:master Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants