Rename Bill's brother to Bill's older sister #1132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that NPC attached to
BillsBrotherScript
had a sprite ofSPRITE_POKEFAN_F
, and wondered if the labels here were maybe incorrect. While I couldn't find anything beyond the sprite itself that seemed particularly definitive, the same house in HGSS also used a similar sprite, and Bulbapedia currently describes Bill as having two sisters (rather than a sister and a brother), so I went ahead and wrote up a commit for all the related renames.Bill having two sisters does introduce some potential for naming collisions (i.e.,
BillsSisterScript
), so I usedBillsYoungerSister
andBillsOlderSister
to avoid this. The Goldenrod NPC being younger than Bill is perhaps a bit more clear from the in-game text/sprites, but Brent's phone gossip script about "Bill's younger sister" would technically be ambiguous if both were younger than Bill, and regardless the Fuchsia NPC would be the older of Bill's two sisters.