-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add release notes for 0.294 #25633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for 0.294 #25633
Conversation
I am done with my initial reviews and have applied my changes. I have pulled the updated branch, made a new doc build, and reviewed the new doc build from beginning to end each time. This PR is ready for the Release Note Shepherd. What I did:
|
There is currently no one identified as the Release Note Shepherd for 0.294. A volunteer from the Presto committers is requested. I believe that the work remaining in this PR for the Shepherd is:
|
* Add pushdownSubfieldArgIndex parameter to ComplexTypeFunctionDescriptor for subfield optimization during query planning. `#25175 <https://github.com/prestodb/presto/pull/25175>`_ | ||
* Add xxhash64 override with seed argument. `#25521 <https://github.com/prestodb/presto/pull/25521>`_ | ||
* Adds aggregation tests from ``presto-tests`` to run with native query runner in ``presto-native-tests``. `#24809 <https://github.com/prestodb/presto/pull/24809>`_ | ||
* Move UnnestNode to SPI, make it available in collector optimizer. `#25317 <https://github.com/prestodb/presto/pull/25317>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry does not begin with a keyword in the Order of changes in the Release Notes Guidelines. I'd like this revised to follow that list. Ideally I ask that this be revised to explain to an end user of Presto, as described in Audience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yhwang, would you look at revising this one? I wasn't sure what to do with it.
@tdcmeehan, a shepherd is needed for this PR for the 0.294 release. Also, there are several entries that I think would benefit from your attention to making them intelligible to an end user of Presto, which is something you've focused on in the last several release notes PRs to good result. In the interests of velocity I'd ask you to, when you have time, review the existing entries with your focus on that aspect. |
@yhwang, when you have time would you address this? The work to do is listed in this comment. Thanks! |
hi @steveburnett update the release notes for those missing items:
also went through the whole list and light touched some of them. compiled the doc and checked the release note in html format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @yhwang! Only a few minor requests. Also, please select some notable entries that you feel worthy to copy into the Highlights section.
* Add pushdownSubfieldArgIndex parameter to ComplexTypeFunctionDescriptor for subfield optimization during query planning. `#25175 <https://github.com/prestodb/presto/pull/25175>`_ | ||
* Add xxhash64 override with seed argument. `#25521 <https://github.com/prestodb/presto/pull/25521>`_ | ||
* Adds aggregation tests from ``presto-tests`` to run with native query runner in ``presto-native-tests``. `#24809 <https://github.com/prestodb/presto/pull/24809>`_ | ||
* Move UnnestNode to SPI, make it available in collector optimizer. `#25317 <https://github.com/prestodb/presto/pull/25317>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yhwang, would you look at revising this one? I wasn't sure what to do with it.
Hi @steveburnett add items to the highlights section. For #25317 I directly use the one that you suggested in the issue. It's hard for me to pick items for the highlights section. I hope it's a good list. Please feel free to revise the list if you see fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work @yhwang! Looks good. The commits need to be squashed before merge, but the words, format, order of sections, order of changes, and links all look good.
@tdcmeehan PTAL.
0d3ae94
to
72e506c
Compare
Hi @steveburnett, I squashed commits, fixed one minor typo, and put two of us as authors in the commit. Thanks for the guidance and review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull updated branch, new local doc build.
@tdcmeehan, please review. |
@rschlussel @arhimondr Can you help review this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the highlights so far, still need to review.
* Improve efficiency of output buffer implementation to reduce memory usage in writer. `#24913 <https://github.com/prestodb/presto/pull/24913>`_ | ||
* Improve query resource usage by enabling subfield pushdown for :func:`map_filter` when selected keys are constants. `#25451 <https://github.com/prestodb/presto/pull/25451>`_ | ||
* Improve query resource usage by enabling subfield pushdown for :func:`map_subset` when the input array is a constant array. `#25394 <https://github.com/prestodb/presto/pull/25394>`_ | ||
* Improve serialized size estimation by introducing a batched API using vectorized operations. It delivers up to 8x faster size estimation compared to the previous row-by-row implementation. Workloads with high serialization cost will benefit from adopting this range-based API. `#25569 <https://github.com/prestodb/presto/pull/25569>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am having trouble understanding what is the practical meaning of this. What does it mean for users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about?
Improve the efficiency of queries that involve with serialization operator by processing data in large group instead of one by one.
* Add property ``native_query_memory_reclaimer_priority`` which controls which queries are killed first when a worker is running low on memory. Higher value means lower priority to be consistent with velox memory reclaimer's convention. `#25325 <https://github.com/prestodb/presto/pull/25325>`_ | ||
* Add pushdownSubfieldArgIndex parameter to ComplexTypeFunctionDescriptor for subfield optimization during query planning. `#25175 <https://github.com/prestodb/presto/pull/25175>`_ | ||
* Add case-sensitive support for column names. It can be enabled for JDBC based connector by setting ``case-sensitive-name-matching=true`` at the catalog level. `#24983 <https://github.com/prestodb/presto/pull/24983>`_ | ||
* Replace ``EXPLAIN (TYPE DISTRIBUTED)`` with ``EXPLAIN (TYPE VALIDATE)`` for faster, lightweight analysis. `#25545 <https://github.com/prestodb/presto/pull/25545>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add some context that this is for the Presto Router and in the context of C++/Java routing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this one, I thought this speeds up the explain
query. not sure about router.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pdabre12 can you help explain this better in the context of the router?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work?
Updated presto-plan-checker-router-plugin
router plugin to use EXPLAIN (TYPE VALIDATE)
in place of EXPLAIN (TYPE DISTRIBUTED)
, enabling faster routing of queries to either native or Java clusters.
@yhwang, please address @tdcmeehan's review of the Highlights. Because some of the feedback involves rewriting the entry, please make the same changes to the duplicate entries where they were copied from into the Highlights. |
Add release notes for 0.294 Co-authored-by: Steve Burnett <[email protected]> Co-authored-by: Timothy Meehan <[email protected]> Co-authored-by: Yihong Wang <[email protected]> Signed-off-by: Yihong Wang <[email protected]>
72e506c
to
8568801
Compare
@tdcmeehan thanks for the comments. I didn't think about user's perspective. and both you and @steveburnett remind me about that. addressed your comments for highlight section and left two question. |
@tdcmeehan , again, thanks for the comments. Addressed all your comments and waiting for inputs from the following PRs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % the pending rewords. If we don't get traction from the authors we can remove most of them.
2bee16b
to
a889134
Compare
Signed-off-by: Yihong Wang <[email protected]>
a889134
to
2b77af4
Compare
Update the notes again:
See the list here |
Thanks a lot @yhwang for driving this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final (I hope) nits. Did a complete review of the page in a local doc build, checked links work as intended, products capitalized as they are used, and so on. These last few tiny nits were all I found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull updated branch, new local doc build, reviewed page in new local doc build. Looks great.
Thanks @yhwang and @tdcmeehan!
Hi @tdcmeehan can we have your LGTM again? And I learned a lot. I can do better the second time. Also, many thanks to @steveburnett |
You did a great job this time! |
Signed-off-by: Yihong Wang <[email protected]> Co-authored-by: Steve Burnett <[email protected]> Co-authored-by: Timothy Meehan <[email protected]> Co-authored-by: Yihong Wang <[email protected]>
Missing Release Notes
Gary Helmling
Shakyan Kushwaha
Zhichen Xu
github username
Extracted Release Notes
TIMESTAMP
column type by changing it from PrestoTIMESTAMP
type toTIMESTAMP_WITH_TIME_ZONE
.TIMESTAMP_NTZ
column type as PrestoTIMESTAMP
type.legacy_timestamp
should be set tofalse
to match delta type specifications. With it set,TIMESTAMP
will not adjust based on local timezone.case-sensitive-name-matching
.case-sensitive-name-matching=true
configuration in the catalog configuration.TestAggregations
to native-tests #24809 (Author: Pramod Satya): [native] AddTestAggregations
to native-testspresto-tests
to run with native query runner inpresto-native-tests
.ANALYZE
.case-sensitive-name-matching=true
at the catalog level.presto-plan-checker-router-plugin
#25035 (Author: Pratik Joseph Dabre): Add a new custom router scheduler plugin :presto-plan-checker-router-plugin
Presto Plan Checker Router Scheduler Plugin <https://github.com/prestodb/presto/tree/master/presto-plan-checker-router-plugin/README.md>
_.MinMaxByToWindowFunction
to rewrite min_by/max_by aggregations with row_number window function.rename view
for Iceberg connector when configured withREST
andNESSIE
.RouterRequestInfo
to get the URL destination.connector/hive:Quick Stats
.com.amazonaws.util.StringUtils
. Addaws-java-sdk-core
as a runtime dependency to support Redshift JDBC driver (v2.1.0.32) which relies on this class for metadata operations.$deleted
metadata column.$delete_file_path
metadata column.$data_sequence_number
metadata column for table with equality deletes.connector/hive:Avro Configuration Properties
to Hive Connector documentation.CVE-2025-27817 <https://github.com/advisories/GHSA-vgq5-3255-v292>
_. :pr:25312
.native_query_memory_reclaimer_priority
which controls which queries are killed first when a worker is running low on memory. Higher value means lower priority to be consistent with velox memory reclaimer's convention.SHOW CREATE TABLE
,SHOW CREATE VIEW
,SHOW COLUMNS
, andDESCRIBE
queries.map_subset
when the input array is a constant array.hive.copy-on-first-write-configuration-enabled
to false (:issue:25404
).MinMaxByToWindowFunction
optimizer to cover cases where aggregation is on both map/array and non map/array types.map_filter
when selected keys are constants.iceberg.delete-as-join-rewrite-max-delete-columns
configuration property anddelete_as_join_rewrite_max_delete_columns
session property to control when equality delete as join optimization is applied. The optimization is now only applied when the number of equality delete columns is less than or equal to this threshold (default: 400). Setting this to 0 disables the optimization. See :doc:/connector/iceberg
for details.iceberg.delete-as-join-rewrite-enabled
configuration property anddelete_as_join_rewrite_enabled
session property. Useiceberg.delete-as-join-rewrite-max-delete-columns
instead.dot_product
to calculate to calculate the sum of element wise product between two identically sized vectors represented as arrays. This function supports both array(real) and array(double) input types. For more information, refer to the Dot Product definition.parse_duration
function for large millisecond values.EXPLAIN (TYPE DISTRIBUTED)
withEXPLAIN (TYPE VALIDATE)
for faster, lightweight analysis.CVE-2025-48924 <https://github.com/advisories/GHSA-j288-q9x7-2f5v>
.TableLocationProvider
interface to decouple table location logic from JDBC configuration.All Commits
isEqualFunction
in FunctionResolution (wangd)AbstractTestQueries
testcases for native-tests (Pramod Satya)AbstractHiveSslTest
(Tim Meehan)