Skip to content

Add native_max_num_splits_listened_to session property (1/2) #25360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kagamiori
Copy link
Contributor

@kagamiori kagamiori commented Jun 18, 2025

Description

Add a session property native_max_num_splits_listened_to in Prestissimo to control the max number of splits that Velox SplitListener listens to. This PR adds the session property on coordinator side. #25361 adds the session property support on worker side.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

@kagamiori kagamiori requested a review from a team as a code owner June 18, 2025 17:27
@kagamiori kagamiori requested a review from ZacBlanco June 18, 2025 17:27
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jun 18, 2025
@kagamiori kagamiori changed the title Add native_max_num_splits_listened_to session property Add native_max_num_splits_listened_to session property (1/2) Jun 18, 2025
@kagamiori kagamiori requested a review from a team as a code owner June 18, 2025 17:32
@kagamiori kagamiori force-pushed the split_listener_session_property branch from dbdbba7 to 479a69e Compare June 18, 2025 17:35
@kagamiori kagamiori requested a review from kewang1024 June 18, 2025 17:51
@steveburnett
Copy link
Contributor

Please add documentation for this new session property. A good place to consider is https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/properties-session.rst.

@kagamiori
Copy link
Contributor Author

Please add documentation for this new session property. A good place to consider is https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/properties-session.rst.

Hi @steveburnett, thank you for reviewing. I've updated properties-session.rst. Could you please take another look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants