fix: apply localization, escape special HTML chars in license strings, CSS changes #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #295 +/- ##
============================================
- Coverage 99.60% 99.22% -0.39%
- Complexity 97 98 +1
============================================
Files 15 15
Lines 511 514 +3
============================================
+ Hits 509 510 +1
- Misses 2 4 +2
☔ View full report in Codecov by Sentry. |
SteelWagstaff
commented
Oct 25, 2023
assets/css/book-card.css
Outdated
| @@ -28,10 +28,19 @@ | |||
| color: var(--primary-dark); | |||
| } | |||
|
|
|||
| .book-cards .book-card .book-info p { | |||
| .book-cards .book-card .book-info * { | |||
There was a problem hiding this comment.
Apply desired font size to all elements in the book card book info block
SteelWagstaff
commented
Oct 25, 2023
| @apply text-base m-0; | ||
| } | ||
|
|
||
| .book-cards .book-card .book-info ol { | ||
| @apply list-decimal list-inside; |
There was a problem hiding this comment.
Apply desired list styling to ordered and unordered lists.
SteelWagstaff
commented
Oct 25, 2023
| @@ -57,7 +66,7 @@ | |||
| @apply mb-2; | |||
| } | |||
|
|
|||
| .book-cards .book-card .book-info .book-description.line-clamp *:not(a):not(em):not(del):not(span):not(strong):not(u) { | |||
| .book-cards .book-card .book-info .book-description.line-clamp *:not(a):not(em):not(del):not(span):not(strong):not(u):not(li) { | |||
There was a problem hiding this comment.
Show the list styling for clamped items
SteelWagstaff
changed the title
arzola
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Book cards print the full name of each book's copyright license. Sometimes, these strings contain apostrophes and other special HTML characters which weren't being unescaped. This PR fixes that problem. It also applies minor CSS improvements to address the display of list items in book cards, and updates the translations for French. Addresses #127, #254, #292 and #293