Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feedback #22

Merged
merged 4 commits into from
Feb 1, 2024
Merged

fix: feedback #22

merged 4 commits into from
Feb 1, 2024

Conversation

fdalcin
Copy link
Contributor

@fdalcin fdalcin commented Feb 1, 2024

This PR addresses comments in #6 (comment).

In addition, it updates the way we handle menu so we have separate endpoints for the listing and forms.

I've also opened greatislander/pressbooks-multiselect#101 against the pressbooks-multiselect component, after release it would allow us to handle the 4th item in the comment.

@arzola arzola self-requested a review February 1, 2024 19:38
Copy link
Contributor

@arzola arzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arzola arzola merged commit 53b3ba6 into dev Feb 1, 2024
6 checks passed
@arzola arzola deleted the fix/feedback branch February 1, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants