feat: add institution info for network/users.php page #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard015ar
commented
Apr 17, 2024
| @@ -65,7 +65,7 @@ public function handlePagesPermissions($institution, $institutionalManagers, $in | |||
| */ | |||
|
|
|||
| add_filter('can_edit_network', function ($canEdit) use ($allowedBooks) { | |||
| if (is_network_admin() && !in_array($_REQUEST['id'], $allowedBooks)) { | |||
| if (is_network_admin() && isset($_REQUEST['id']) && !in_array($_REQUEST['id'], $allowedBooks)) { | |||
There was a problem hiding this comment.
I got PHP Warning: Undefined array key "id" in /app/web/app/plugins/pressbooks-multi-institution/src/Services/PermissionsManager.php on line 68 when going to user.php (standard list) as an IM.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #159 +/- ##
============================================
- Coverage 82.63% 82.58% -0.05%
- Complexity 289 307 +18
============================================
Files 32 33 +1
Lines 1589 1642 +53
============================================
+ Hits 1313 1356 +43
- Misses 276 286 +10 |
richard015ar
changed the title
richard015ar
commented
Apr 18, 2024
| @@ -188,8 +188,10 @@ private function currentUserHasAccess(string $currentPageParam, array $allowedBo | |||
| $institutionalUsers = apply_filters('pb_institutional_users', []); | |||
|
|
|||
| if ($currentPageParam === 'pb_network_analytics_userlist' || $pagenow === 'users.php' || $pagenow === 'user-edit.php') { | |||
| if (isset($_REQUEST['user_id']) && in_array($_REQUEST['user_id'], $institutionalUsers)) { | |||
| $isAccessAllowed = true; | |||
| $isAccessAllowed = true; | |||
There was a problem hiding this comment.
we can go to users.php list without having any $_REQUEST value as it has in edit/delete actions. In that case, we want to allow it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #42
This PR modifies the WP network user list in order to add an "Institution" sortable column with the institution name. If the user displayed in the list does not belong to any institution, it displays
Unnasignedtext.Testing case
Institutioncolumn is displayed after theEmailone with the correct value.Institutioncolumn and make sure the ordering is correct.<NETWORK_URL>/network/user-edit.php?user_id=<USER_ID_FROM_OTHER_INSTITUTION>. You should not be allowed to do that.Super Adminfilter at the top of the table is not available.