Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Twitter & YouTube icons #1290

Merged
merged 7 commits into from
Dec 18, 2024
Merged

fix: update Twitter & YouTube icons #1290

merged 7 commits into from
Dec 18, 2024

Conversation

SteelWagstaff
Copy link
Member

@SteelWagstaff SteelWagstaff commented Dec 16, 2024

Replace Twitter and YouTube icons to match changes made in pressbooks/pressbooks-aldine#474. Add a new SVG for email. Use new social sharing options defined in pressbooks/pressbooks#3870

Copy link
Contributor

@arzola arzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely sure why you are using the pressbooks-aldine namespace instead of pressbooks-book

@SteelWagstaff
Copy link
Member Author

Oops -- that was a mistake. Will fix with a new commit. Nice catch.

@SteelWagstaff SteelWagstaff requested a review from arzola December 17, 2024 23:59
Copy link
Contributor

@arzola arzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arzola arzola merged commit 305d5b3 into dev Dec 18, 2024
4 checks passed
@arzola arzola deleted the fix/update-twitter-info branch December 18, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants