Skip to content

Commit

Permalink
change: consolidate ci npm and upgrade node (#1148)
Browse files Browse the repository at this point in the history
  • Loading branch information
arzola authored Jan 24, 2023
1 parent d2d0719 commit 1846334
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 30 deletions.
29 changes: 1 addition & 28 deletions .github/workflows/build-and-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,4 @@ on:
branches: [ dev ]
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node: [ '14', '16', '18' ]
name: Node ${{ matrix.node }}
steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}

- name: Cache node modules
uses: actions/cache@v3
with:
path: node_modules
key: ${{ runner.OS }}-build-${{ hashFiles('**/package-lock.json') }}

- name: Install Node dependencies & build assets
run: |
node -v
npm ci
npm run build
- name: Run Lint
run: npm run lint
uses: pressbooks/composer-autoupdate-bedrock/.github/workflows/lint-build.yml@v1
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v18
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"author": "Pressbooks (Book Oven Inc.)",
"license": "GPL-3.0-or-later",
"engines": {
"node": ">= 14"
"node": ">= 18"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit 1846334

Please sign in to comment.