Skip to content

Commit

Permalink
v2.5.1 (#430)
Browse files Browse the repository at this point in the history
* Update README.md

* fix: check if has editors before trying to render them

* Update version

Co-authored-by: Felipe Dalcin <[email protected]>
Co-authored-by: Ricardo Aragon <[email protected]>
  • Loading branch information
3 people authored Oct 29, 2021
1 parent 4c87555 commit f509b3f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pressbooks-directory",
"version": "2.5.0",
"version": "2.5.1",
"engines": {
"node": ">=14.0.0 <15.0.0",
"npm": ">=6.0.0 <7.0.0"
Expand Down
5 changes: 4 additions & 1 deletion src/components/books/BookDetails.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
data-cy="book-authors"
/>
<meta-info
v-if="item.hasEditor"
v-if="hasEditor"
title="Editor(s): "
:text="editors"
data-cy="book-editors"
Expand Down Expand Up @@ -105,6 +105,9 @@ export default {
hasSubjects() {
return this.item.about && this.item.about.length > 0;
},
hasEditor(){
return this.item.editor && this.item.editor.length > 0;
},
authors() {
return this.item.author.join(', ');
},
Expand Down

0 comments on commit f509b3f

Please sign in to comment.