Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [bot] Run grit migration: Class to Functional - AlteredSliceTag #683

Closed
wants to merge 4 commits into from

Conversation

grit-app[bot]
Copy link

@grit-app grit-app bot commented Nov 22, 2023

⚠️ This migration is out of date with the main branch. Update with Grit ⚠️

⚠️ This pull request was auto-generated with Grit. ⚠️

This pull request was created with these settings:

  • Target branch: master
  • Source files: superset-frontend/src/components/AlteredSliceTag/index.jsx
  • Preset pattern: react_to_hooks – This pattern converts React class components to functional components, with hooks.
Pattern body
engine marzano(0.1)
language js

// Most of the logic for this pattern is in react_hooks.grit
// https://github.com/getgrit/js/blob/main/.grit/patterns/react_hooks.grit

pattern regular_first_step() {
  $use_ref_from = .,
  $handler_callback_suffix = "Handler",
  first_step($use_ref_from, $handler_callback_suffix)
}

sequential {
    file(body = program(statements = some bubble($program) regular_first_step())),
    // Run it 3 times to converge
    file(body = second_step(handler_callback_suffix = "Handler")),
    file(body = second_step(handler_callback_suffix = "Handler")),
    file(body = second_step(handler_callback_suffix = "Handler")),
    file($body) where {
      $body <: program($statements),
      $statements <: bubble($body, $program) and {
        maybe adjust_imports(),
        add_more_imports(),
      }
    }
}

Please feel free to provide feedback on this pull request. Any comments will be incorporated into future migrations.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f00404) 69.13% compared to head (bde992e) 69.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   69.13%   69.12%   -0.01%     
==========================================
  Files        1941     1941              
  Lines       75893    75850      -43     
  Branches     8450     8431      -19     
==========================================
- Hits        52466    52429      -37     
+ Misses      21252    21250       -2     
+ Partials     2175     2171       -4     
Flag Coverage Δ
hive 53.68% <ø> (ø)
mysql 78.16% <ø> (ø)
postgres 78.26% <ø> (ø)
presto 53.63% <ø> (ø)
python 82.95% <ø> (ø)
sqlite 76.91% <ø> (ø)
unit 55.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eschutho eschutho force-pushed the grit/8d87ae06-afaa-469d-abfb-1846398e01eb branch from 15f7a6a to 68f0ec1 Compare November 28, 2023 23:55
@eschutho eschutho changed the title [bot] Run grit migration: Apply a GritQL pattern chore: [bot] Run grit migration: Class to Functional - AlteredSliceTag Nov 30, 2023
@grit-app grit-app bot force-pushed the grit/8d87ae06-afaa-469d-abfb-1846398e01eb branch from 6e034d8 to bde992e Compare November 30, 2023 23:44
Copy link
Author

grit-app bot commented Nov 30, 2023

Updated pull request with a migration run from base commit 4f00404. View run

I have backed up the previous version of this pull request on branch grit-backup/225d64a1-cbbe-4bf7-9905-d30a4b895d3b.

@eschutho eschutho force-pushed the grit/8d87ae06-afaa-469d-abfb-1846398e01eb branch from bde992e to 7f0b782 Compare December 1, 2023 00:49
@eschutho eschutho force-pushed the grit/8d87ae06-afaa-469d-abfb-1846398e01eb branch from 7f0b782 to f4b2ecb Compare January 8, 2024 17:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants