Clear refreshGuestToken interval on unmount #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the interval continues to run even after we've used unmount()
|
Hi @gamma613, thank you so much for this contribution to the Preset SDK! Would you be willing to contribute this PR to the Apache Superset repository, instead? The Superset repository is OSS and therefore you can contribute this change for proper ownership. The Preset SDK has a different license model and therefore only Preset employees are able to contribute. If you can contribute this change to the OSS repo, we can then incorporate these changes to our SDK as well. |
|
Closing in favor or #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the interval continues to run even after we've used unmount()