fix: Clearing token refresh interval on unmount (#22)

* Clearing token refresh interval on unmount * Bumping node version
preset-io · Mar 25, 2024 · f890e38 · f890e38
1 parent 930fc69
commit f890e38
Show file tree

Hide file tree

Showing 5 changed files with 66 additions and 20 deletions.
diff --git a/.github/workflows/embedded-sdk-release.yml b/.github/workflows/embedded-sdk-release.yml
@@ -12,7 +12,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: "16"
+          node-version: "18"
           registry-url: 'https://registry.npmjs.org'
       - name: release
         run: |

diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+18.19.1
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@preset-sdk/embedded",
-  "version": "0.1.9",
+  "version": "0.1.10",
   "description": "Frontend SDK for embedding Preset data analytics into your own application",
   "access": "public",
   "keywords": [
@@ -43,7 +43,7 @@
     "@babel/preset-env": "^7.16.11",
     "@babel/preset-typescript": "^7.16.7",
     "@types/jest": "^27.4.1",
-    "axios": "^0.25.0",
+    "axios": "^1.6.8",
     "babel-loader": "^8.2.3",
     "jest": "^27.5.1",
     "typescript": "^4.5.5",

diff --git a/src/index.ts b/src/index.ts
@@ -131,21 +131,23 @@ export async function embedDashboard({
     fetchGuestToken(),
     mountIframe(),
   ]);
+  let refreshGuestTokenInterval: number | undefined;
 
   ourPort.emit('guestToken', { guestToken });
   log('sent guest token');
 
   async function refreshGuestToken() {
     const newGuestToken = await fetchGuestToken();
     ourPort.emit('guestToken', { guestToken: newGuestToken });
-    setTimeout(refreshGuestToken, getGuestTokenRefreshTiming(newGuestToken));
+    refreshGuestTokenInterval = setTimeout(refreshGuestToken, getGuestTokenRefreshTiming(newGuestToken));
   }
 
-  setTimeout(refreshGuestToken, getGuestTokenRefreshTiming(guestToken));
+  refreshGuestTokenInterval = setTimeout(refreshGuestToken, getGuestTokenRefreshTiming(guestToken));
 
   function unmount() {
     log('unmounting');
     mountPoint?.replaceChildren();
+    clearTimeout(refreshGuestTokenInterval);
   }
 
   const getScrollSize = () => ourPort.get<Size>('getScrollSize');