fix(import-assets): Include all dashboard depedencies when using the the --split flag #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitor-Avila
commented
May 9, 2024
Comment on lines
+328
to
+330
| for filter_config in config["metadata"].get("native_filter_configuration", []): | ||
| for target in filter_config["targets"]: | ||
| if uuid := target.get("datasetUuid"): |
There was a problem hiding this comment.
From my tests:
- Even if the dashboard doesn't have any elements, it always have the
positionandmetadatakeys/configurations. - If the dashboard never had a filter created, it might not include the
native_filter_configurationkey. - Even filters that don't have a target (such as temporal) still include a blank
targetskey. - If the filter dataset was deleted, its
targetconfig won't have adatasetUuidfield.
eschutho
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sync native/import-assetscommand allows users to include a--splitflag to import resources individually. It's possible to create dashboard filters using datasets that aren't used by any chart. The logic was currently not including these datasets when importing the dashboard, resulting in an import error.