Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dbt): Remove Redshift-specific column metadata #291

Merged
merged 2 commits into from
May 9, 2024
Merged

fix(dbt): Remove Redshift-specific column metadata #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f877a3
fix(dbt): Remove Redshift-specific column metadata
Vitor-Avila May 9, 2024
fe99670
Addressing pre-commit issue
Vitor-Avila May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/preset_cli/cli/superset/sync/dbt/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def clean_metadata(metadata: Dict[str, Any]) -> Dict[str, Any]:
"precision",
"scale",
"max_length",
"info",
):
if key in metadata:
del metadata[key]
Expand Down
3 changes: 3 additions & 0 deletions tests/cli/superset/sync/dbt/datasets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,6 +1433,9 @@ def test_clean_metadata() -> None:
"precision": "very precise",
"scale": "to the max",
"max_length": 9000,
"info": {
"custom_info": "blah",
},
}
result = clean_metadata(test_data)
assert result == {
Expand Down
Loading