Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbt): Avoid raising an error when syncing specific models #289

Merged
merged 1 commit into from
May 1, 2024

Conversation

Vitor-Avila
Copy link
Contributor

The CLI allows users to sync specific models via dbt. As a consequence, when evaluating metrics it's expected that some will rely on models that aren't included in the model_map. This PR changes the logic to avoid raising a ValueError in this scenario and instead just ignore the metric.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Vitor-Avila Vitor-Avila merged commit e1ed229 into main May 1, 2024
5 checks passed
@Vitor-Avila Vitor-Avila deleted the metrics-fix branch May 1, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants