Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todo highlighting in html comments #642

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Todo highlighting in html comments #642

wants to merge 4 commits into from

Conversation

lggruspe
Copy link
Contributor

Fixes #369

Highlights TODO, FIXME, XXX and TBD inside html comments.

alerque
alerque previously approved these changes Sep 20, 2023
View reviewed changes
alerque
alerque requested changes Sep 20, 2023
View reviewed changes
Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests not passing, I'm guessing the behavior is correct just the expectations are incorrect.

test/syntax.vader Show resolved Hide resolved
@lggruspe
Copy link
Contributor Author

I made the tests pass, but there are still some issues with this PR. Currently, it can't detect TODO comments without a preceding space. For example,

<!--TODO this doesn't get highlighted -->
<!-- TODO but this one does -->

@lggruspe lggruspe marked this pull request as draft September 22, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add todo highlighting in the html comments
3 participants
@lggruspe @alerque @wincent