Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added toggle for displaying symlink destination #1367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rzvxa
Copy link
Member

@rzvxa rzvxa commented Sep 5, 2023

Description of Changes

Added an option to settings for showing or hiding symlink destinations.
Note:
This actually hides the special highlighting for symlink, As its highlighting depends on the -> mark being present and I've tried to reflect that in the documentation.
Changing this behavior may need changes to the way symlinks are represented so we can highlight them without the destination path being present.


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merging, tag the commit using these (Mac-compatible) bash commands:
    git checkout master
    git pull
    sed -n "$(grep -n -m2 '####' CHANGELOG.md | cut -f1 -d: | sed 'N;s/\n/,/')p" CHANGELOG.md | sed '$d'
    git tag -a $(read -p "Tag Name: " tag;echo $tag) -m"$(git show --quiet --pretty=%s)";git push origin --tags

@rzvxa
Copy link
Member Author

rzvxa commented Oct 9, 2023

@alerque I would appreciate it if you review this one too, It's been hanging out here for over a month.

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome to do the honors here and merge. Since it's a single discrete change I think the merge commit from master is kind of irrelevant, but at this point you can just use the "squash and merge" feature in the PR to get the PR merged using one commit to the master branch.

As far as I'm concerned this is good to go, but if you want to add any changelog stuff you can still do that here before merging and still use squash to get it all down to one commit for how it pulls through to most plugin managers...

@rzvxa
Copy link
Member Author

rzvxa commented Oct 23, 2023

Thanks, I was holding back on merging this one until some feedback came.
I'm not sure if this change is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants