Drop incorrect port #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Rack::Request#url` includes the port of the original request (despite accurate scheme updates). This becomes an issue when LB terminates SSL: - client request is made to https://example.com:443, - LB request is http://example.com:80 - build_api_url returns correct scheme but wrong port: https://example:80 Since we only need the request url from the env, this changeset manually fetches the correct scheme (Rack accounts for FWD headers already), the host (w/out port as opposed to #host_with_port), and the fullpath (pathname + query params) Another benefit of this changeset is that it no longer mutates the original env object (assigning to `new_env` is by reference). Caveat: im dropping @options[:protocol] bc there's x-fwd-proto should handle this already.
|
whops. i meant to open this pr against my own fork. since this is an issue that might affect others, im gonna leave it open here for discussion. let me know if you have any questions |
kshsieh
force-pushed
the
pr-fix-host
branch
2 times, most recently
from
26a8545
to
27b1ea5
Compare
- Reinstating custom support for CF-VISITOR CloudFlare header + options[:protocol] - Fixing failing tests Instead of passing in `X-Forwarded-Proto` to the Rack env, we can now safely rely on `HTTP_` env variables which are automatically set. Per https://github.com/rack/rack/blob/master/SPEC.rdoc#the-environment-: HTTP_ Variables: Variables corresponding to the client-supplied HTTP request headers (i.e., variables whose names begin with HTTP_). The presence or absence of these variables should correspond with the presence or absence of the appropriate HTTP header in the request. See RFC3875 section 4.1.18 for specific behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rack::Request#urlincludes the port of the original request (despiteaccurate scheme updates). This becomes an issue when LB terminates SSL:
https://example:80
Since we only need the request url from the env, this changeset manually
fetches the correct scheme (Rack accounts for FWD headers already), the
host (w/out port as opposed to #host_with_port), and the fullpath
(pathname + query params)
Another benefit of this changeset is that it no longer mutates the
original env object (assigning to
new_envis by reference).Caveat: im dropping@options[:protocol]bcx-fwd-protoshouldhandle this already.