Skip to content

Improve texture mapping and F8 wait diagnostics - #4

Merged
prematurely merged 3 commits into
mainfrom
codex/release-cs-wait-20261114
Nov 14, 2026
Merged

prematurely merged 3 commits into
mainfrom
codex/release-cs-wait-20261114

Conversation

@prematurely

@prematurely prematurely commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Changes

  • Extend F8 measurement coverage and tail-event storage, including CS chunk and Vulkan command-buffer interval correlation for resource waits.
  • Reuse initialized texture mappings and defer bounded mapping retirement while retaining resource dependencies and the Vulkan staging/copy path.
  • Mark telemetry unavailable in the runtime snapshot and report header when backend events are dropped, remain unread, or are still in flight at capture stop. An in-flight operation during an active capture does not by itself mark the capture incomplete.
  • Add resource lifetime, LockRect, mapping-budget, telemetry, and evidence-analysis regression coverage, and forward the resolved Ninja and glslang paths to mapping probes.

Validation

  • The original 53-file candidate matched its frozen source manifest and baseline snapshot. Follow-up commits fix hosted test-tool path forwarding and telemetry completeness reporting; the latter changes the Bridge source and has not been deployed to the game.
  • Existing complete local Release x86 validation of the original candidate: 112 passed, 0 failed; two optional external source audits skipped because external paths were not supplied.
  • Real-backend telemetry completeness regression: before the fix, backend ring overflow and stop-boundary in-flight/late events produced six missing-status failures; after the fix, 107 checks passed. The test injects a one-event capacity and a bounded pause at the real backend unmap boundary, while drop/in-flight counters come from the backend. A span that completes before stop does not set the telemetry unavailable bit.
  • The final local pipeline recorded 110 passed, 3 failed, and 2 optional skips. Its telemetry completeness gate passed (106 checks, 0 failures). Two failed Bridge evidence checks passed in targeted reruns using the archived audited reference DLL after the installed game DLL had changed; the third, CS allocation correlation, passed a targeted real-device rerun with 34 checks and a 25.6895 ms observed overlap after the original run did not trigger the intended allocation. These are targeted reruns, not a clean single full-pipeline run.
  • Final hosted Windows CI: build, tests, package and package layout passed; the results artifact records 43 passed and 72 optional skips, with no required skips. GPU and environment-sensitive probes, including the telemetry completeness gate, are skipped on the hosted runner.
  • The first hosted run failed the LRU gate because Ninja and glslang paths were not forwarded; a real LLVM/LRU regression reproduced the missing path and then passed 57 checks after the test-only fix.
  • Existing normal capture fixture: 13 checks passed, no loss, unavailable mask 18, storage complete. The sealed-empty boundary fixture: 18 checks passed; a real span crossing stop is explicitly incomplete. Fresh analysis tests: CS wait analysis 4/4, tail and mapping evidence validation 11/11.
  • Prior real-device tests checked pixel readback, resource retirement, Reset/Release, CS correlation, and bounded performance with cleanup and GPU drain included. Historical game wait attribution and the deployed build's first-exit gameplay result still require a new F8 capture.

Retain initialized texture mappings, defer bounded mapping retirement, and extend F8 coverage with CS wait correlation. Add runtime, resource lifetime, and analysis regression coverage.
Copilot AI balanced review requested due to automatic review settings November 14, 2026 04:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T04:39:27.891121Z dec429b New commits
🔒 Security Review ✅ Completed 2026-11-14T04:40:54.535793Z dec429b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ebdb256b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@prematurely
prematurely merged commit 178cc1b into main Nov 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants