Repository navigation
Fix measurement lifecycle reviews and preserve sampler batching - #2
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three post-merge measurement reviews from #1 while preserving the existing generic sampler optimization. A multithreaded Reset could deadlock with a Present callback reading diagnostics; a secondary device could claim the selected capture's thread; ANSI module enumeration could break symbol lookup for Unicode installation paths.
Changes:
Validation:
f6876b2f: 85 passed / 0 failed / 2 skipped. Both skips require external source/config inputs; GPU and environment-sensitive gates ran. All 87 per-gate logs were integrity checked and hashed. The final documentation commit changes no product or test code.The earlier full run's two setup failures are retained: the historical ABI gate requires the original archived reference, while its default selected the currently installed game DLL. The complete suite passed with the explicit hash-verified reference, without weakening assertions. Local Clang 22 instability was handled by pinning compiler descendants only; runtime/benchmark affinity stayed normal.
Validation report · Raw paired evidence and gate hashes
Public interfaces, rendering quality and Vulkan staging/copy paths are retained. No game DLL, configuration or symbol file was replaced; all eight installed-file hashes match the pre-task snapshot. The game installation remains unchanged, and this PR will remain open for review.
Remote validation completed:
Build, test, and packagecheck is SUCCESS for headaadc8e0c48474f71c7137725b6f15fab44c6df2d.33bd259532b4879cca8a8eb6af29d1150a67d2ea. Its tree2bd1b3f5dc9f521aad2c509e4f69416bfd51a243exactly matches the PR head tree.