Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add xaxis.range[0]/[1] If Not Exist #335 #336

Closed
wants to merge 1 commit into from

Conversation

yzhaoinuw
Copy link
Contributor

Fix #335.
When xaxis.range[0] and xaxis.range[1] do not exist in relayoutdata after resetting axes, add them separately from xaxis.range if it exists. This way the traces should be updated.

@jonasvdd
Copy link
Member

jonasvdd commented Mar 6, 2025

ps. to make it way more easier to review, you should at least add a test with your desired behavior that first fails, then create the fix, and verify whether that test passes :)

@jonasvdd jonasvdd self-requested a review March 6, 2025 08:31
@jonasvdd jonasvdd added the bug Something isn't working label Mar 6, 2025
@jonasvdd
Copy link
Member

jonasvdd commented Mar 6, 2025

However, your issues was well described, and I was able to create the necesarry tests! :)

@jonasvdd
Copy link
Member

jonasvdd commented Mar 6, 2025

I think you did not give the maintainers editor access, I will try to fix this on a fork (where I will also perform a rebase to make the testing work)

@jonasvdd jonasvdd closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Resetting Axes Doesn't Reset Trace If X-Axis Range Is Set
2 participants