Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multigrid settings to flow-over-heated-plate SU2 config #571

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

j-signorelli
Copy link
Contributor

This PR adds multigrid settings to the flow-over-heated-plate SU2 config file, speeding up runtime.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@uekerman
Copy link
Member

Could you please briefly document how much the speedup here is? Is it already significant for such a small mesh? Thanks!

@j-signorelli
Copy link
Contributor Author

j-signorelli commented Sep 11, 2024

Yes of course: on my system with 3 MPI procs, without multigrid took ~444 seconds and with these multigrid settings took 168 seconds, so the speedup is 2.5-3x improvement.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tried to run this, but I trust that this should only improve the speed of the tutorial.

I assume you have checked that results are still the same, right?

https://precice.org/tutorials-flow-over-heated-plate.html#compare-results

@j-signorelli
Copy link
Contributor Author

Yep! Results are indeed still the same.

@MakisH MakisH merged commit 3855e79 into precice:develop Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants