Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.3.1 #333

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Release v1.3.1 #333

merged 8 commits into from
Jun 27, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Jun 26, 2024

Bugfix release, mainly fixing the volume-coupled-flow tutorial and the pre-commit hook.

Pending:

@MakisH MakisH marked this pull request as ready for review June 27, 2024 05:59
@MakisH MakisH requested a review from davidscn June 27, 2024 06:00
@MakisH MakisH self-assigned this Jun 27, 2024
@MakisH
Copy link
Member Author

MakisH commented Jun 27, 2024

The system tests are failing for the perpendicular-flap. I will look into the results in 1-2h, but this could just be a false alarm due to extra files being generated (currently only presumably so).

@MakisH
Copy link
Member Author

MakisH commented Jun 27, 2024

(Edit: wrong versions are used)

The system tests are failing with actual numerical differences:

field-compare-1  | Comparing files in the directories '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/precice-exports' and '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/reference-results-unpacked/fluid-openfoam_solid-calculix'
field-compare-1  | 
field-compare-1  | Comparing '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/precice-exports/Fluid-Mesh-Fluid.dt500.vtk'
field-compare-1  |       and '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/reference-results-unpacked/fluid-openfoam_solid-calculix/Fluid-Mesh-Fluid.dt500.vtk'
field-compare-1  |   Reading '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/precice-exports/Fluid-Mesh-Fluid.dt500.vtk'
field-compare-1  |   Reading '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/reference-results-unpacked/fluid-openfoam_solid-calculix/Fluid-Mesh-Fluid.dt500.vtk'
field-compare-1  |    -- Comparing the field 'Force': FAILED
field-compare-1  |      -- Report: Deviation above tolerance detected -> [ 9.106287596856326   -0.05966103813265446  0.                 ] vs. [ 9.106277276921778   -0.05965746570060117  0.                 ] ([ 0.00 -0.01   inf] %)
field-compare-1  |      -- Predicate: DefaultEquality (abs_tol: 0., rel_tol: 3.e-07)
field-compare-1  |    -- Comparing the field 'Displacement': FAILED
field-compare-1  |      -- Report: Deviation above tolerance detected -> [0.0001706923844161843  0.00029547016613652846 0.                    ] vs. [0.00017066859115197518 0.00029542253804797254 0.                    ] ([0.01 0.02  inf] %)
field-compare-1  |      -- Predicate: DefaultEquality (abs_tol: 0., rel_tol: 3.e-07)
field-compare-1  |   File comparison FAILED with 1 PASSED / 2 FAILED / 0 SKIPPED

@MakisH
Copy link
Member Author

MakisH commented Jun 27, 2024

I updated the preCICE version as well and the system tests pass. I should have done this here, so the tests helped!

@MakisH MakisH merged commit 94e78ea into master Jun 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants