Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit for liniting docs #321

Merged
merged 5 commits into from
Mar 10, 2024

Conversation

fsimonis
Copy link
Member

This PR adds pre-commit hooks for linting the markdown docs as well as ensuring added images have the correct prefix.

@fsimonis fsimonis requested a review from MakisH February 19, 2024 16:17
@fsimonis
Copy link
Member Author

The corresponding workflow is still missing.
Which branches need to be checked?

@MakisH
Copy link
Member

MakisH commented Mar 5, 2024

The corresponding workflow is still missing. Which branches need to be checked?

The develop branch is the one rendered on the website. Will you add the workflow as well?

@fsimonis
Copy link
Member Author

fsimonis commented Mar 5, 2024

Done. I removed the markdown workflow as it is now covered by pre-commit.

@MakisH
Copy link
Member

MakisH commented Mar 7, 2024

Can you please also add a quick mention in the CONTRIBUTING.md?

https://github.com/precice/openfoam-adapter/blob/develop/CONTRIBUTING.md

@fsimonis
Copy link
Member Author

fsimonis commented Mar 8, 2024

Done

@MakisH MakisH self-assigned this Mar 10, 2024
@MakisH MakisH added the dev Not directly affecting users, but helping future development label Mar 10, 2024
@MakisH MakisH merged commit 8175b7a into precice:develop Mar 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Not directly affecting users, but helping future development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants