-
-
Notifications
You must be signed in to change notification settings - Fork 7
API with and without null-terminated strings #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…ll-terminated strings
Co-authored-by: Ivan Pribec <[email protected]>
|
Together with @ivan-pi, we took now a different approach: Instead of differentiating between null- and non-null-terminated strings in the C interface, we just adopt the de facto Fortran calling convention, as already done in the core library. We dropped the We also removed the dimension arguments present in the Important here would be that this would need special handling on Windows Fortran compilers, which adopt a different convention. We would need to specify We modified the |
Closes #1, implementing (to the extent I understand) the suggestions of @ivan-pi.
I also tried to make the length an optional argument, to maintain compatibility with user code. I am also trying to avoid touching the preCICE C/Fortran bindings for now, as we just had a breaking release.
Currently, building the (unmodified)
solverdummy.f90leads to the following error:Any clue what I am doing wrong?