Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict to mpi4py<4 #35

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Restrict to mpi4py<4 #35

merged 1 commit into from
Mar 12, 2025

Conversation

BenjaminRodenberg
Copy link
Member

Main changes of this PR

Restrict to mpi4py<4 in setup.py

Motivation and additional information

#33 fails (presumably due to mpi4py problem). In precice/fenics-adapter#181 we implemented the identical fix.

Author's checklist

  • I updated the changelog file CHANGELOG.md if there are user-observable changes since the last release. (skipping because this is a rather technical detail and we have not officially released the fenicsx adapter)
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@BenjaminRodenberg BenjaminRodenberg added the bug Something isn't working label Mar 12, 2025
@BenjaminRodenberg BenjaminRodenberg self-assigned this Mar 12, 2025
@BenjaminRodenberg BenjaminRodenberg added this to the v0.1.0 milestone Mar 12, 2025
@BenjaminRodenberg
Copy link
Member Author

Will merge this now. Note that the failure of the test above will be fixed via #33. I also verified in #33 that the fix provided here actually fixes the installation procedure.

@BenjaminRodenberg BenjaminRodenberg merged commit 358bf80 into develop Mar 12, 2025
8 of 9 checks passed
@BenjaminRodenberg BenjaminRodenberg deleted the restrict_mpi4py branch March 12, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant