Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the changes we did to our version of the format script to the original precommit hook ? #80

Closed
Toddelismyname opened this issue Feb 1, 2025 · 3 comments
Labels
question Further information is requested

Comments

@Toddelismyname
Copy link
Contributor

Toddelismyname commented Feb 1, 2025

@VanLaareN I also tried to apply the changes we did to our version of the format script to the original precommit hook.
See format_precice_config_hook.py
I tried running it on our generated unformatted precice-config: 5f2ff0b
and the result was: 81f5702

I think we could ask uekerman if we should make a pull request to the precice pre commit hook. What do you think ? 👍

I already forked their repo and commited the current state without creating a pr: https://github.com/Toddelismyname/precice-pre-commit-hooks/tree/structured-reordering

Originally posted by @Toddelismyname in #79 (comment)

@Toddelismyname Toddelismyname added the question Further information is requested label Feb 1, 2025
@Toddelismyname
Copy link
Contributor Author

@uekerman @fsimonis
Should we make a pr with our changes applied to the hook script ?

@fsimonis
Copy link

fsimonis commented Feb 4, 2025

@Toddelismyname Yes, please do.

@Toddelismyname
Copy link
Contributor Author

Toddelismyname commented Feb 5, 2025

@VanLaareN I redid the fork to be on the forschungsprojekt organization instead of my personal account. Somehow I missed that before. https://github.com/precice-forschungsprojekt/precice-pre-commit-hooks/tree/structured-reordering

I opened a pr as a draft for now: precice/precice-pre-commit-hooks#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants