Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance and Test preCICE Configuration Formatter #90

Open
Toddelismyname opened this issue Feb 5, 2025 · 2 comments · May be fixed by #91
Open

Enhance and Test preCICE Configuration Formatter #90

Toddelismyname opened this issue Feb 5, 2025 · 2 comments · May be fixed by #91
Assignees
Labels
enhancement New feature or request

Comments

@Toddelismyname
Copy link
Contributor

Toddelismyname commented Feb 5, 2025

Enhance and Test preCICE Configuration Formatter

Objective

Improve the validation and testing of the preCICE configuration formatter to support the transition of PR #3 from a draft to a fully implemented feature. (The changes there also need to be applied to our own subscript that is not a cli-script with args)

Background

The current pre-commit hook for preCICE configs on precice/precice-pre-commit-hooks#3 needs further refinement/testing to ensure robust and comprehensive formatting of configuration files.

Related Issues

Expected Outcomes

  • Robust pre-commit hook for preCICE configuration formatting
  • Improved reliability of configuration files
  • Easier debugging and configuration management
@Toddelismyname Toddelismyname added the enhancement New feature or request label Feb 5, 2025
@Toddelismyname Toddelismyname self-assigned this Feb 5, 2025
@Toddelismyname Toddelismyname changed the title Enhance and Test preCICE Configuration Formater Enhance and Test preCICE Configuration Formatter Feb 5, 2025
@Toddelismyname
Copy link
Contributor Author

Pull request on original pre-commit hook has been marked as ready for review. All changes requested there also need to be applied to our changed up script. Otherwise i hope this is finished

@Toddelismyname Toddelismyname linked a pull request Feb 6, 2025 that will close this issue
@Toddelismyname
Copy link
Contributor Author

Another idea i had was to use the formatter to sort alphabetically everything and then call it on both the original and the generated precice config. Then you can just compare line by line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant