Testing config along with minimal changes to resolve failing tests #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update README with command to run tests with tox and docker. Not all tests are passing. Failures (that aren't XFAILS) are mainly due to line endings. Test results expect \r\n but are only getting \n. Guessing previous tests were all run on windows?
- Tried to apply smallest possible change. I will eventually do something about the formatting.
Main fixes: - Requires lxml to pass these tests - The rest was all changes to the BeautifulSoup API - convertEntities is no longer a valid parameter, and the value passed to it is unnecessary. The functionality is replaced by the features kwarg, which in this case I set to xml. - Silenced some deprecation warnings by changing fromEncoding to from_encoding -- from_encoding is effectively ignored in python 3, but probably still required in python 2 - NavigabeString class exists on the beautifulsoup4 module, so reference was updated.
- Added latex tests to tox.ini Most of these were bytes vs unicode issues. Tried using the unicode_literals import where possible, but turns out there are some peculiar interactions between it and raw strings. Ended up not using the import in the Latex writer.
- Install pdftohtml in test Dockerfile - Add pdf tests to tox.ini - Use six.BytesIO instead of StringIO - coerce some strings to bytes where needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the most elegant changes.
There are a fair few type coercions to make sure that we have bytes going with bytes and unicode with unicode.
Rest of the fixes tended to be swapping out StringIOs for six.BytesIO, or updating for BeautifulSoup changes or fiddling with newlines
I didn't update the setup.py requirements or url.
The test config uses tox to configure the dependencies and run tests against both python 2.7 and 3.6.
Dockerfile base image comes with tox and a bunch of python versions installed so it's relatively easy to include others. It starts failing once you get to 3.8