-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/docker support #87
base: master
Are you sure you want to change the base?
Conversation
package.json
Outdated
@@ -4,7 +4,7 @@ | |||
"description": "A workflow for Angular made with Webpack", | |||
"scripts": { | |||
"build": "rimraf dist && webpack --bail --progress --profile", | |||
"server": "webpack-dev-server --host 0.0.0.0 --port 8080 --history-api-fallback --inline --progress", | |||
"server": "webpack-dev-server --history-api-fallback --inline --progress", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was the command changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted it by this commit. In the first place, I wanted to use webpack-dev-server and I needed to change host to 0.0.0.0 to make it work (to fix ERR_CONNECTION_REFUSED error). But then I realized that it's better to use separated web-server (in this case express) and build command because webpack-dev-server is not good for production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i don't know if this should be part of the scope of this starter project, also because it's a client-side only application so benefits of using docker are very limited (or not existing at all)
@phra benefit from using Docker is good starting point for deploy on production. You right, it's a client-side app, but it needs to be deployed someday, and with Docker, it can be easily done. |
@phra I think with docker included it becomes a good entry point for people who are looking for a simple enough client side app setup with a backend for frontend(e.g. the node server). Anybody can work from there and make it a full-fledged deployable solution. But, I agree that for a simple enough client app(e.g. a static portfolio or demo page), it might be an overkill. |
Docker support was added. For build, run, stop commands shell scripts were created. Port and container name can be specified. NodeJS + express was used as simple web server.