feat: Add schema-driven adapter configuration #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The schemas/ directory was being ignored by .gitignore (intended for AdCP schema cache files). Added exception for src/adapters/schemas/ to allow the adapter schema infrastructure module to be tracked. Also cleaned up unused imports flagged by ruff. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ures Replace hardcoded start_time/end_time dates with dynamic dates that are always in the future (tomorrow + 30 days). This prevents test failures when the previously hardcoded date (2026-02-01) rolls into the past. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove separate src/adapters/schemas/ registry module. Instead: - Add capabilities and config classes directly on adapter classes - Simple get_adapter_schemas() function in src/adapters/__init__.py - Keeps same API but with simpler implementation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bokelley
changed the title
Resolves merge conflicts by accepting main's dynamic date approach using _get_future_date_range() in integration tests. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
BaiyuScope3
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds schema-driven adapter configuration with capabilities and connection config classes on adapter classes directly.
Changes:
capabilitiesandconnection_config_classclass attributes toAdServerAdapterMockConnectionConfigandMockProductConfigPydantic schemas to Mock adapterget_adapter_schemas()helper insrc/adapters/__init__.pyconfig_jsoncolumn toAdapterConfigmodel (database migration)Also includes:
Test plan
get_adapter_schemas("mock")🤖 Generated with Claude Code