Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medianet: Add fledge support #3794

Closed
wants to merge 3 commits into from

Conversation

bhavye-g
Copy link

@bhavye-g bhavye-g commented Jul 5, 2024

Add Fledge support for Medianet adapter. The response from bidder for fledge auction config support the ortb format mentioned in the below link.
https://github.com/InteractiveAdvertisingBureau/openrtb/blob/main/extensions/community_extensions/Protected%20Audience%20Support.md

Previously opened MR that got closed because developer account was removed
#3641

Copy link

github-actions bot commented Jul 5, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 858444f

medianet

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/medianet/medianet.go:43:	MakeRequests		75.0%
github.com/prebid/prebid-server/v2/adapters/medianet/medianet.go:64:	MakeBids		85.7%
github.com/prebid/prebid-server/v2/adapters/medianet/medianet.go:113:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/medianet/medianet.go:121:	getMediaTypeForImp	85.7%
github.com/prebid/prebid-server/v2/adapters/medianet/medianet.go:137:	extractFledge		100.0%
github.com/prebid/prebid-server/v2/adapters/medianet/medianet.go:162:	buildEndpoint		88.9%
total:									(statements)		87.9%

@onkarvhanumante
Copy link
Contributor

@bhavye-g PR tests are failing with following error. Should rectify it to proceed with code reviews

ok  	github.com/prebid/prebid-server/v2/adapters/lunamedia	0.027s	coverage: 89.9% of statements
ok  	github.com/prebid/prebid-server/v2/adapters/mabidder	0.026s	coverage: 95.2% of statements
ok  	github.com/prebid/prebid-server/v2/adapters/madvertise	0.029s	coverage: 90.0% of statements
ok  	github.com/prebid/prebid-server/v2/adapters/marsmedia	0.026s	coverage: 74.3% of statements
--- FAIL: TestJsonSamples (0.00s)
    test_json.go:130: medianettest/exemplary/fledge.json: MakeBids had wrong error count. Expected 0, got 1 ([Unable to fetch mediaType for imp: 1])
FAIL
coverage: 76.8% of statements
FAIL	github.com/prebid/prebid-server/v2/adapters/medianet	0.027s
FAIL

@media-net media-net closed this by deleting the head repository Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants