Test: Price floors max rules dimensions #3646

marki1an · 2024-12-20T12:33:27Z

🔧 Type of changes

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

verify email contact works
NO fully dynamic hostnames
geographic host parameters are NOT required
direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

osulzhenko

Please add test cases that cover the following:

request-level max-schema-dims config cannot be passed in the request; it must be specified as part of the account config (i.e., ignore ext.prebid.floors.max-schema-dims).
default value for max-schema-dims is 3.
What happens if both fetch.max-schema-dims and max-schema-dims are set with different values? Which one takes priority?

osulzhenko · 2024-12-24T14:34:27Z

src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsFetchingSpec.groovy

@@ -2046,6 +2046,91 @@ class PriceFloorsFetchingSpec extends PriceFloorsBaseSpec {
        }
    }

+    def "PBS should validate fetch.max-schema-dims from account config"() {
+        given: "Default BidRequest"
+        def bidRequest = BidRequest.getDefaultBidRequest(APP)


also why APP?

…les-dimensions' into tests/price-floors-max-rules-dimensions

osulzhenko · 2025-01-07T11:10:41Z

src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsSignalingSpec.groovy

+import spock.lang.IgnoreRest

 import static org.mockserver.model.HttpStatusCode.BAD_REQUEST_400
 import static org.prebid.server.functional.model.Currency.USD
 import static org.prebid.server.functional.model.bidder.BidderName.GENERIC
+import static org.prebid.server.functional.model.pricefloors.DeviceType.PHONE


invalid imports

osulzhenko · 2025-01-07T11:55:10Z

src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsSignalingSpec.groovy

+                ["Failed to parse price floors from request, with a reason: " +
+                         "Price floor rules number 2 exceeded its maximum number 1"]


This is not the proper way to configure tests. For any external viewer, it will be hard to understand why it is set to 2 and why we are using 1. A person would be forced to look at the code and into PriceFloorSchema.groovy for the request. This is not right. We should replace 2 with priceFloorSchema.fields.size and 1 with priceFloorSchema.fields.size - 1 (as example). Same for others

osulzhenko · 2025-01-07T12:04:51Z

src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsFetchingSpec.groovy

+        PBSUtils.randomNegativeNumber | null
+    }
+
+    def "PBS should validate price-floor.max-schema-dims from account config"() {


PBS should validate price-floor.max-schema-dims from account config and not reject entire auction same for others

osulzhenko

Also, please add some privacy methods for these counts:

foo.ext.prebid.floors.data.modelGroups[0].values.size()
boo.ext.prebid.floors.data.modelGroups[0].schema.fields.size()

osulzhenko · 2025-01-07T16:50:43Z

src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsSignalingSpec.groovy

+        assert response.ext?.errors[PREBID]*.message ==
+                ["Failed to parse price floors from request, with a reason: " +
+                         "Price floor rules number ${ampStoredRequest.ext.prebid.floors.data.modelGroups[0].values.keySet().size()} " +
+                         "exceeded its maximum number 1"]


replace 1 with maxRules value. Same for others. Also maybe we can use ${ampStoredRequest.ext.prebid.floors.data.modelGroups[0].values.size()}

we can't just replace with maxRules, since

maxRules | maxRulesSnakeCase 1 | null null | 1

Let's then make it constant

osulzhenko · 2025-01-07T17:08:42Z

src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsSignalingSpec.groovy

+    def "PBS shouldn't emit errors when request schema.fields than floor-config.max-schema-dims"() {
+        given: "Bid request with schema 2 fields"
+        def bidRequest = bidRequestWithFloors.tap {
+            ext.prebid.floors.maxSchemaDims = PBSUtils.randomNumber


because it can be flaky, pls add:
ext.prebid.floors.maxSchemaDims = PBSUtils.getRandomNumber(2) 2 as example here

osulzhenko · 2025-01-08T08:48:43Z

src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsSignalingSpec.groovy

+                "'$BASIC_FETCH_URL$accountId', account = $accountId with a reason : Price floor schema dimensions 2 " +
+                "exceeded its maximum number 1")


Price floor schema dimensions ${getSchemaSize(bidRequest)}

osulzhenko · 2025-01-08T08:49:26Z

src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsSignalingSpec.groovy

+        assert response.ext?.errors[PREBID]*.message ==
+                ["Failed to parse price floors from request, with a reason: " +
+                         "Price floor rules number ${ampStoredRequest.ext.prebid.floors.data.modelGroups[0].values.keySet().size()} " +
+                         "exceeded its maximum number 1"]


Let's then make it constant

osulzhenko · 2025-01-08T08:53:29Z

src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsSignalingSpec.groovy

+            config.auction.priceFloors.maxSchemaDims = 2
+            config.auction.priceFloors.fetch.maxSchemaDims = 1


config.auction.priceFloors.maxSchemaDims = getSchemaSize(bidRequest) config.auction.priceFloors.fetch.maxSchemaDims = getSchemaSize(bidRequest) - 1

src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsSignalingSpec.groovy

marki1an added 2 commits December 20, 2024 14:30

Add functional tests for price floors max rules dimensions

3b230a0

Update naming

40ee5a8

marki1an added the tests Functional or other tests label Dec 20, 2024

marki1an self-assigned this Dec 20, 2024

Update tests

f72cd25

osulzhenko requested changes Dec 24, 2024

View reviewed changes

osulzhenko reviewed Dec 24, 2024

View reviewed changes

Net-burst mentioned this pull request Jan 6, 2025

Price Floors: Max Rules and Max Dimensions #3630

Merged

21 tasks

marki1an added 3 commits January 6, 2025 23:59

Update after review

79bfd0d

Merge remote-tracking branch 'refs/remotes/origin/price-floors-max-ru…

4665081

…les-dimensions' into tests/price-floors-max-rules-dimensions

Update after review

2889b77

osulzhenko requested changes Jan 7, 2025

View reviewed changes

marki1an added 2 commits January 7, 2025 15:20

Update after review

e3d885e

Update after review

f5d3e6f

osulzhenko requested changes Jan 7, 2025

View reviewed changes

Update after review

230c487

osulzhenko requested changes Jan 8, 2025

View reviewed changes

marki1an added 2 commits January 8, 2025 11:47

Update after review

3965783

Update after review

312263b

osulzhenko approved these changes Jan 8, 2025

View reviewed changes

osulzhenko merged commit 4097c12 into price-floors-max-rules-dimensions Jan 8, 2025

osulzhenko deleted the tests/price-floors-max-rules-dimensions branch January 8, 2025 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test: Price floors max rules dimensions #3646

Test: Price floors max rules dimensions #3646

marki1an commented Dec 20, 2024 •

edited

Loading

osulzhenko left a comment

osulzhenko Dec 24, 2024

osulzhenko Jan 7, 2025

osulzhenko Jan 7, 2025

osulzhenko Jan 7, 2025

osulzhenko left a comment

osulzhenko Jan 7, 2025

marki1an Jan 7, 2025

osulzhenko Jan 8, 2025

osulzhenko Jan 7, 2025 •

edited

Loading

osulzhenko Jan 8, 2025

osulzhenko Jan 8, 2025

osulzhenko Jan 8, 2025

		["Failed to parse price floors from request, with a reason: " +
		"Price floor rules number 2 exceeded its maximum number 1"]

		"'$BASIC_FETCH_URL$accountId', account = $accountId with a reason : Price floor schema dimensions 2 " +
		"exceeded its maximum number 1")

		config.auction.priceFloors.maxSchemaDims = 2
		config.auction.priceFloors.fetch.maxSchemaDims = 1

Test: Price floors max rules dimensions #3646

Test: Price floors max rules dimensions #3646

Conversation

marki1an commented Dec 20, 2024 • edited Loading

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🔎 New Bid Adapter Checklist

🧪 Test plan

🏎 Quality check

osulzhenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

osulzhenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

osulzhenko Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marki1an commented Dec 20, 2024 •

edited

Loading

osulzhenko Jan 7, 2025 •

edited

Loading