Merge pull request #913 from preactjs/fix/avoid-replacing-regex-group…

…-token-with-matched-results (fix) Avoid replacing regex group token when present in html
preactjs · Apr 4, 2022 · caf7ff8 · caf7ff8
2 parents 11663db + 21ec4f4
commit caf7ff8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/six-pandas-look.md b/.changeset/six-pandas-look.md
@@ -0,0 +1,5 @@
+---
+'wmr': patch
+---
+
+When prerendering avoid replacing regex group token \$1 when is present in html contents
diff --git a/packages/wmr/src/lib/prerender.js b/packages/wmr/src/lib/prerender.js
@@ -211,10 +211,10 @@ async function workerCode({ cwd, out, publicPath, customRoutes }) {
 			html = html.replace(/(<html(\s[^>]*?)?>)/, `<html lang="${enc(head.lang)}">`);
 		}
 
-		html = html.replace(/(<\/head>)/, headHtml + '$1');
+		html = html.replace(/(<\/head>)/, (_, groupMatched) => headHtml + groupMatched);
 
 		// Inject pre-rendered HTML into the start of <body>:
-		html = html.replace(/(<body(\s[^>]*?)?>)/, '$1' + body);
+		html = html.replace(/(<body(\s[^>]*?)?>)/, (_, groupMatched) => groupMatched + body);
 
 		// Write the generated HTML to disk:
 		await fs.mkdir(path.dirname(outFile), { recursive: true }).catch(Object);

diff --git a/packages/wmr/test/fixtures/prerender-data/index.js b/packages/wmr/test/fixtures/prerender-data/index.js
@@ -1,3 +1,3 @@
 export function prerender() {
-	return { html: '<h1>it works</h1>', links: ['/'], data: { hello: 'world' } };
+	return { html: '<h1>it works$1</h1>', links: ['/'], data: { hello: 'world' } };
 }