Skip to content

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Oct 17, 2025

Fixes #775

The problem is the following

  • Storybook accesses the text-node props
  • getter returns { data: signal }
  • Storybook recursively processes props.data
  • Since the signal has React element decorations, it's treated as a valid React element
    and we recurse further

The solution here is to access .value to return a plain value.

EDIT: hah, looks like tests won't pass as we're relying on react accessing this property later when the sync-external-store runs
EDIT 2: attempt 2 doesn't work either as react will bail for these strict equal props 😅 this is a bit of a pickle

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2025

⚠️ No Changeset found

Latest commit: 697eedb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 697eedb
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/68f1e386078b520008de69a8
😎 Deploy Preview https://deploy-preview-776--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Size Change: +24 B (+0.02%)

Total Size: 99.4 kB

Filename Size Change
docs/dist/assets/client.********.js 46.2 kB +25 B (+0.05%)
docs/dist/react-********.js 241 B -1 B (-0.41%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/bench.********.js 1.59 kB
docs/dist/assets/devtools.********.js 955 B
docs/dist/assets/index.********.js 835 B
docs/dist/assets/jsxRuntime.module.********.js 297 B
docs/dist/assets/preact.module.********.js 4.72 kB
docs/dist/assets/signals-core.module.********.js 1.56 kB
docs/dist/assets/signals.module.********.js 2.56 kB
docs/dist/assets/style.********.css 1.27 kB
docs/dist/assets/style.********.js 21 B
docs/dist/basic-********.js 246 B
docs/dist/nesting-********.js 1.13 kB
packages/core/dist/signals-core.js 1.59 kB
packages/core/dist/signals-core.mjs 1.6 kB
packages/debug/dist/debug.js 3.64 kB
packages/debug/dist/debug.mjs 3.18 kB
packages/preact-transform/dist/signals-*********.js 1.3 kB
packages/preact-transform/dist/signals-transform.mjs 1.29 kB
packages/preact-transform/dist/signals-transform.umd.js 1.42 kB
packages/preact/dist/signals.js 1.7 kB
packages/preact/dist/signals.mjs 1.66 kB
packages/react-transform/dist/signals-*********.js 6.89 kB
packages/react-transform/dist/signals-transform.mjs 6.09 kB
packages/react-transform/dist/signals-transform.umd.js 7.01 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

@JoviDeCroock JoviDeCroock marked this pull request as draft October 17, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant