Clear class component refs on unmount in compat - #5225
Open
contactjawad wants to merge 1 commit into
Open
contactjawad wants to merge 1 commit into
contactjawad wants to merge 1 commit into
Conversation
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An object ref on a class component isn't reset to
nullwhen the component unmounts (preact/compat):In
unmount()the ref is only cleared whenr.currentis falsy or equals the vnode's DOM node. For a compat class component the ref points at the component instance (vnode._component), so neither case matches and the stale instance is left behind. DOM refs and function refs are already cleared — it's just the instance case slipping through.I added
r.current == vnode._componentto that guard. Ran the refs suite too to check nothing regressed. Test added.