Conversation
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
rschristian
left a comment
There was a problem hiding this comment.
Thanks for taking a swing at implementing this! Few comments though, mostly minor (in addition to what Jovi's already said):
|
As I tried to make clear in my suggestions/comments, the philosophy of preact is to optimize for performance and size. We should also not leak implementation details into core for the sake of it. EDIT: thinking more about the |
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
rschristian
left a comment
There was a problem hiding this comment.
I'm not sure we can get away with using useContext or useState, both fundamentally break the promise of use in that it can be conditionally called.
|
Second to @rschristian. |
close #4756