Prevent memo'd components that unsuspend from bailing #4711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummary⏳ Benchmarks are currently running. Results below are out of date. duration
usedJSHeapSize
Results⏳ Benchmarks are currently running. Results below are out of date. create10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
compat/src/suspense.js
Outdated
Comment on lines
61
to
62
| // issue #4631 | ||
| if (vnode.type.name === 'Memoed') vnode._component._force = true; |
There was a problem hiding this comment.
Suggested change
| // issue #4631 | |
| if (vnode.type.name === 'Memoed') vnode._component._force = true; | |
| vnode._component._force = true; |
There was a problem hiding this comment.
This does not fix #3449 yet, for that you would need a different mechanism in error-boundaries. That being said this also needs tests
|
Thanks |
JoviDeCroock
requested changes
Feb 26, 2025
JoviDeCroock
reviewed
Mar 1, 2025
compat/test/browser/suspense.test.js
Outdated
| @@ -2159,4 +2160,38 @@ describe('suspense', () => { | |||
| expect(scratch.innerHTML).to.equal('<div><p>hello world</p></div>'); | |||
| }); | |||
| }); | |||
|
|
|||
| it('should correctly render memod child component', () => { | |||
There was a problem hiding this comment.
This test does not test the behaviour, it even passes on main. You might want to look at the reproduction to more closely reproduce the failure. Currently this component renders successfully and retains said state, what we want to assert is that it can attain new state
|
@JoviDeCroock Hi there, could you plz check this pr? Thanks for your time~ |
JoviDeCroock
approved these changes
Mar 20, 2025
JoviDeCroock
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
MemoComponent to when unsuspending_forceso when the subsequent render arrives there is no possibility of bailing out of the render pass.fixes #4631