(major) - Tracking PR for v11 #4549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: -1.41 kB (-2.26%) Total Size: 61 kB
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
v11-2
branch
4 times, most recently
from
af99557 to
067be2b
Compare
|
#4406 would be another easy thing to fit in, swapping out our (pretty much unused & problematic) |
JoviDeCroock
force-pushed
the
v11-2
branch
2 times, most recently
from
a12176d to
14ea8f6
Compare
JoviDeCroock
force-pushed
the
v11-2
branch
2 times, most recently
from
5caed5c to
39339b2
Compare
JoviDeCroock
force-pushed
the
v11-2
branch
2 times, most recently
from
d328910 to
41622b2
Compare
developit
reviewed
Feb 11, 2025
* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file
JoviDeCroock
commented
Feb 12, 2025
| * is smaller than including a dedicated polyfill. | ||
| * @param {import('./index').ContainerNode} node The node to remove | ||
| */ | ||
| export function removeNode(node) { |
There was a problem hiding this comment.
@developit the perf regression still stands after undoing the assign change so I am thinking this might be related to removeNode
* Forward ref by default * Optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
Component.baseSuspenseListmodule.jsrefactor: Breaking changes to outputs & pkg.json #4652If you need this you can always polyfill it by doing
options.vnode = (vnode) => { if (vnode.props.ref) { vnode.ref = vnode.props.ref; delete vnode.props.ref; } }Under consideration
defaultPropsfrompreactand intopreact/compatMovedefaultPropsintopreact/compat#4657TODO